feat(router): optional router in AddTaskButton #4176
Conversation
|
""" WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AddTaskButton
participant Router
participant InternalNavHandler
User->>AddTaskButton: Clicks menu item
alt routerDisabled is true and handler exists
AddTaskButton->>InternalNavHandler: handle(internalSidebarNavigation + open: true, true)
else
AddTaskButton->>Router: history.replace({ state: { open: true } })
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4181. You may have to fix your CI before adding the pull request to the queue again. |
3266c3f
485137e
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4183. You may have to fix your CI before adding the pull request to the queue again. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4184. You may have to fix your CI before adding the pull request to the queue again. |
AddTaskButton is now accepting routerDisabled prop and acts accordingly using routing handlers instead of ReactRouter. Tests were converted to RTL and expanded.
Summary by CodeRabbit
New Features
Tests