This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Added ES SimpleClient support for annotations backend #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captncraig
suggested changes
Oct 24, 2016
backend/backend.go
Outdated
| initialized bool | ||
| index string | ||
| urls []string | ||
| SimpleClient bool |
There was a problem hiding this comment.
does not need to be exported. May as well be simpleClient.
Contributor
Author
|
@captncraig had faced issue while building added few more changes :) |
captncraig
approved these changes
Oct 24, 2016
|
Cool. Can you update the vendored version in bosun in your pr there? Try |
Contributor
Author
|
Done 👍 |
pradeepbbl
pushed a commit
to bookingcom/annotate
that referenced
this pull request
Oct 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was part of bosun-monitor/bosun#1947 supporting ES SimpleClient