This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: Fix silence logic #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
How about a test to go with this? I realize it might be longer than the code, but I think it's super important that we get into the habit of writing tests when bosun has bugs in its operational logic. Bosun is complicated enough that we will change some little thing somewhere else, and we need to make sure that change doesn't affect other parts. Tests are a good way to do that. |
Member
Author
|
Do you have something I can look at it that will give me a starting point to write the test? |
madelynnblue
added a commit
that referenced
this pull request
Mar 11, 2015
cmd/bosun: Fix silence logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769