这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conversation

@johnewing1
Copy link
Contributor


Description

Remove unneeded string() cast that now triggers vet check in go 1.15

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • Vet check now passes
  • Unit tests all pass

Checklist:

  • This contribution follows the project's code of conduct
  • This contribution follows the project's contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

muffix
muffix previously approved these changes Sep 4, 2020
@johnewing1 johnewing1 merged commit a4ce7ec into bosun-monitor:master Sep 4, 2020
neilfordyce pushed a commit that referenced this pull request Jul 15, 2024
* Remove unneeded string() cast that now triggers vet check in go 1.15

* Remove string() cast in favour of Itoa

Co-authored-by: John Ewing <john.ewing@skyscanner.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants