这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conversation

@vburlai
Copy link
Contributor

@vburlai vburlai commented Feb 27, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Description

There was a typo in mimmax aggregator function name and I get the following error when try using it:

No such aggregation function: minmax

Type of change

From the following, please check the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

The change has not been tested.
This is the only occurance of minmax keyword in the whole repo, so I assume it should work.

Checklist:

  • This contribution follows the project's code of conduct
  • This contribution follows the project's contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@muffix muffix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vburlai, thanks for your contribution. 🙌 It's a good spot and generally looks great, but the Travis build is failing. There are some instructions in the contributing guidelines on how to run go generate bosun.org/... - which is required after changing typescript files. Would you mind running that and updating the PR?

Happy to merge once that's done. 👍

@vburlai
Copy link
Contributor Author

vburlai commented Mar 5, 2020

Regenerated static bundle

@muffix muffix self-requested a review March 5, 2020 12:31
Copy link
Member

@muffix muffix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks @vburlai 🙌

@muffix muffix merged commit 7c99ecf into bosun-monitor:master Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants