这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conversation

@zkrapavickas
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Description

Currently it is possible to specify name of unknownTemplate in rules configuration file. The issue is that unknown template name are parsed and assigned (bosun/conf/rule/rule.go line 195) but never actually used in code. As a result only static internal template are used.

Fixes #2446 (fill in)
#2446

Type of change

From the following, please check the options that are relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Currently running in our internal environment.

Checklist:

  • This contribution follows the project's code of conduct
  • This contribution follows the project's contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Žilvinas Krapavickas and others added 5 commits February 6, 2020 13:19
pass RulesConf to notify functions
use global unknown template if specified
Issue: #2444

RuleConfProvider return configured UnknownTemplate
pass RulesConf to notify functions
use global unknown template if specified

fix coding style

coding style fix
pass RulesConf to notify functions
use global unknown template if specified
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default unknown template is used despite unknownTemplate being specified

2 participants