This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Use unknownTemplate if it is configured #2450
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Description
Currently it is possible to specify name of unknownTemplate in rules configuration file. The issue is that unknown template name are parsed and assigned (bosun/conf/rule/rule.go line 195) but never actually used in code. As a result only static internal template are used.
Fixes #2446 (fill in)
#2446
Type of change
From the following, please check the options that are relevant.
How has this been tested?
Currently running in our internal environment.
Checklist: