-
Notifications
You must be signed in to change notification settings - Fork 492
Add ElasticSearch 7.x support #2440
Conversation
muffix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harudark, thanks a lot for your contribution. 🙌
Looking great so far, just a couple of small questions/comments. Would you mind having a look at them and rebasing your branch on master so that we can get it in?
go.sum
Outdated
| github.com/aws/aws-sdk-go v0.0.0-20180507225419-00862f899353/go.mod h1:ZRmQr0FajVIyZ4ZzBYKG5P3ZqPz9IHG41ZoMu1ADI3k= | ||
| github.com/aws/aws-sdk-go v1.1.33 h1:AebOM+6ucC+bSl36BQrYkwShiqruxxJrZKduAvXSD1A= | ||
| github.com/aws/aws-sdk-go v1.1.33/go.mod h1:ZRmQr0FajVIyZ4ZzBYKG5P3ZqPz9IHG41ZoMu1ADI3k= | ||
| github.com/aws/aws-sdk-go v1.25.25 h1:j3HLOqcDWjNox1DyvJRs+kVQF42Ghtv6oL6cVBfXS3U= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run go mod tidy against that? It seems like we've got multiple versions in here and tidying up might get rid of the dupes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, I forgot it and will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, happy to merge this once that's done (and rebased on the latest master). Thanks again for the contribution. 🙌
|
any news on that? |
johnewing1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks for adding this functionality
Description
This pull request adds ES 7.x support in Bosun.
I submitted #2427 before but that is based on my own go modules migration pull request which is different from what upstream maintainers did. This one is based on upstream go modules migration.
Type of change
From the following, please check the options that are relevant.
How has this been tested?
Tested with ES 7.2 and also ES 6.8 to make sure nothing breaks.
Checklist: