This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Update docker setup #2479
Merged
Update docker setup #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the Docker buiild setup. We can now build a complete docker container with Bosun, Scollector, tsdbrelay, OpenTSDB and HBase directly from the Dockerfile in cmd/bosun/docker/run
Adds a separate Dockerfile for OpenTSDB and HBase so that it can be reused elsewhere.
Adds an easy way to bring up the entire stack with docker-compose. This brings up two containers, one with OpenTSDB and HBase, and a second one with bosun, scollector and tsdbrelay.
Moves the directory with all Docker-related files into the repository root because it does more than just build a Bosun container. So it doesn't make sense to have it in cmd/bosun.
Updates the documentation with the latest information on how to run Bosun and its dependencies in Docker.
|
SonarCloud Quality Gate failed.
|
Adds some information on running Redis in Docker to the documents. This will be useful when trying to debug database interaction.
Removes environment variables used during the Docker build process and replaces them with ARGs so that these variables aren't exposed to the container.
f328a1b to
43391a3
Compare
johnewing1
approved these changes
May 14, 2020
Contributor
johnewing1
left a comment
There was a problem hiding this comment.
Good to get an update version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the Docker files in the repo so that it's possible and easy again to bring up Bosun and/or its dependencies in Docker.
The
docker-compose.ymlfile brings up three containers:Just run
docker-compose -f docker/Dockerfile up.This will eventually enable better testing.
Type of change
How has this been tested?
docker-composeChecklist:
Any dependent changes have been merged and published in downstream modules