This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Add Github actions #2477
Merged
Add Github actions #2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a script that tests whether Bosun starts and stops cleanly. Mostly taken from the old `validate.sh` script
1c88337 to
e75ae7d
Compare
johnewing1
reviewed
May 12, 2020
.github/workflows/ci.yaml
Outdated
| jobs: | ||
| checks: | ||
| name: Code style | ||
| runs-on: ubuntu-latest |
Contributor
There was a problem hiding this comment.
Is is possible to pin this ? Otherwise is there the potential for changes in ubuntu base image to break the builds
johnewing1
reviewed
May 12, 2020
Makefile
Outdated
| @if [ -n "$$(git status --porcelain)" ]; then \ | ||
| echo "There are uncommitted changes in the repository."; \ | ||
| @if [ -n "$$(git diff --exit-code --name-only)" ]; then \ | ||
| echo "There following files are uncommitted changes in the repository:"; \ |
Adds a Github actions pipeline that builds the binaries, runs all tests and checks. This can eventually replace Travis or some parts that are run in its pipeline.
Formats all imports with goimports so that we're starting in a state that the linter is happy
Instead of installing typescript globally, take it from the package.lock file to that it installs typescript into the local node_modules directory
e75ae7d to
f5b5371
Compare
johnewing1
approved these changes
May 12, 2020
Contributor
johnewing1
left a comment
There was a problem hiding this comment.
Thanks for the fixes. Looks good now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Github actions pipeline that builds the binaries, runs all tests and checks. This can eventually replace Travis or some parts that are run in its pipeline.
Also adds a check that all source files have been formatted with
goimports. This explains the reordering of imports in this PR.Type of change
From the following, please check the options that are relevant.
How has this been tested?
Checklist:
Any dependent changes have been merged and published in downstream modules