这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conversation

@muffix
Copy link
Member

@muffix muffix commented May 11, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Description

Fixes a bug that was introduced with #2439 which now requires the
initialisation of the HostManager on startup. That was forgotten to add
to the tsdbrelay command, causing it to panic on startup.

Fixes: #2475

Type of change

From the following, please check the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Tested manually since the fix is part of main()
  • Automated tests for the HostManagers as added previously

Checklist:

  • This contribution follows the project's code of conduct
  • This contribution follows the project's contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Fixes a bug that was introduced with bosun-monitor#2439 which now requires the
initialisation of the HostManager on startup. That was forgotten to add
to the tsdbrelay command, causing it to panic on startup.

Fixes: 2475
@muffix muffix merged commit e22dea9 into bosun-monitor:master May 11, 2020
Copy link
Member

@tdinucci tdinucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: tsdbrelay panicking on startup

3 participants