这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conversation

@johnewing1
Copy link
Contributor

@johnewing1 johnewing1 commented May 18, 2020


Description

Replaces PR #2262 .
Internal version of this functionality had diverged sufficiently from original PR that it is cleaner to start afresh

Requires a role with the ListMetrics and GetMetricData capabilities.
Role can be supplied using either the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables or by attaching it to the EC2 instance on which bosun runs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • CloudWatch query functionality had good unit test coverage
  • Has been used in production in Skyscanner for several years

Checklist:

  • This contribution follows the project's code of conduct
  • This contribution follows the project's contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@johnewing1 johnewing1 changed the title WIP: Adds support for directly querying cloudwatch metrics via the AWS SDK Adds support for directly querying cloudwatch metrics via the AWS SDK May 19, 2020
chudleycannon
chudleycannon previously approved these changes Jun 4, 2020
* Fix panic when dimension string is missing :

Parse dimensions didn't correctly handle invalid dimension strings and would panic on bad input. e.g. those missing a : character.
@johnewing1
Copy link
Contributor Author

@neilfordyce Now includes the parseDimensions fix

@neilfordyce
Copy link
Contributor

Looking good. Nice work on the wildcard dimensions, they make cloudwatch much easier to work with.

@johnewing1 johnewing1 merged commit a62816b into bosun-monitor:master Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants