This repository was archived by the owner on Feb 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 492
Add test coverage report generation #2481
Merged
Merged
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffix
reviewed
May 13, 2020
johnewing1
commented
May 14, 2020
Makefile
Outdated
| go test -covermode=count -coverprofile=coverage.out `go list ./... | grep -v integration` | ||
| go tool cover -html=coverage.out | ||
|
|
||
| .PHOHY: checks |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a typo here from the original makefile H/N
Would it be cleaner to have a single PHONY directive at the top of the file ?
Reduces repetition
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe. I don't really mind. 👍
muffix
previously approved these changes
May 14, 2020
Member
muffix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's see how Sonarclud works.
… config to exclude tests and vendored packages
…the existing targets
muffix
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add targets for generating coverage reports. Initial version of sonar config to exclude tests and vendored packages
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Description
Add two features.
Short cut for generating and viewing coverage reports by running
make coverageAdded step to generate coverage report as part of checks for use by sonarcloud
Type of change
From the following, please check the options that are relevant.
How has this been tested?
Makefile steps verified locally
Checklist: