这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conversation

@muffix
Copy link
Member

@muffix muffix commented May 13, 2020

Description

Wraps the help text into comments so that they are still visible to
contributors, but won't show up on the PR itself.

Example for the PR template:
image

Type of change

From the following, please check the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • Sent through a markdown renderer

Checklist:

  • This contribution follows the project's code of conduct
  • This contribution follows the project's contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@muffix muffix force-pushed the update-templates branch from bbce37a to 63e26ea Compare May 13, 2020 13:42
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.3% 4.3% Duplication

@muffix muffix force-pushed the update-templates branch 2 times, most recently from 1328c6b to fd3caf6 Compare May 14, 2020 11:21
johnewing1
johnewing1 previously approved these changes May 14, 2020
Copy link
Contributor

@johnewing1 johnewing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wraps the help text into comments so that they are still visible to
contributors, but won't show up on the PR itself.
@muffix muffix merged commit 0b1996c into bosun-monitor:master May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants