This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: Add jsonStr template function #2255
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #2197 and #2243.
jsonStr template function is a new better version of its ancestor
.RemoveQuotes. The .RemoveQuotes helper is a temporary patch that helps
to sanitise data in order to use it inside JSON string literals.
Unfortunately it does not handle all characters (e.g.
\n) but only", so at times resulting JSON documents still would be malformed. Thatresults in failure to deliver notifications.
The new version "jsonStr" works just like "json", but it cuts front and
rear double quotes off. So now one can include any template rubbish
inside JSON string literal and worry about breaking JSON not: