This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: add percentiles to window func #2254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captncraig
reviewed
May 18, 2018
| if isPerc { | ||
| fnArgs = append(fnArgs, reflect.ValueOf(fromScalar(percValue))) | ||
| } | ||
| fnResult := windowFn.Call(fnArgs) |
Contributor
There was a problem hiding this comment.
Where is the code that actually detects the new argument and applies the percentile? I'm still confused what windowFn.Call does differently with the new parameter.
Contributor
There was a problem hiding this comment.
Oh, nevermind. It actually takes another arg. And gets selected by name and reflection above. Gotcha. LGTM
captncraig
approved these changes
May 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.