This repository was archived by the owner on Feb 13, 2025. It is now read-only.
ICMP Improvements #2238
Closed
ICMP Improvements #2238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f61cc2 to
b7915c2
Compare
context switches, and allow graphing the RTT and resolution success for pings. Provide options to override ICMP intervals and timeouts on a per-host basis.
Contributor
|
Wow, that seems pretty cool. Will need to look it over pretty closely, but it does seem to be a good improvement. I was never very pleased with how that all worked. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rewrite of the icmp collector. It replaces go-fastping with go-multiping a library I wrote with scollector in mind.
With the current ICMP implementation, go-fastping opens a raw socket for each host being pinged, and then must process every ICMP packet the host receives to find the one it is looking for. We have some scollector hosts which ping over 1000 hosts, so every 15 seconds, 1000 raw socket listeners are started, and 1000 go-fastping threads must each process all 1000 responses to find the one they want.
This new implementation opens only one socket, and calls the appropriate handler for a given response.
This implementation also delays the first ping for a random duration up to the configured interval to even out the spikes of icmp traffic.
This PR also adds the ability to override the timeout and interval for individual hosts and on non-windows systems adds a metric for graphing the TTL on ICMP responses which can give insight into routing changes.