This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Added new api endpoint /api/debug/{key} #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@pradeepbbl Thanks for this, can you move them to /api/health instead? Maybe just a notifications object inside the current root object with these counters. |
Contributor
Author
|
@kylebrandt thanks for the review, made the requested changes do let me know if need any further changes. Thanks, |
Member
|
@pradeepbbl Not sure why the short links commit is in here, rebase on master and force push to your branch maybe? |
Contributor
Author
|
Sorry my bad instead rebase I did a merge :(
…On 19 Feb 2018 11:59 PM, "Kyle Brandt" ***@***.***> wrote:
@pradeepbbl <https://github.com/pradeepbbl> Not sure why the short links
commit is in here, rebase on master and force push to your branch maybe?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2222 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGjlfk6I3paUnxbM2eeBoYzf31-lK21Vks5tWfzNgaJpZM4SG6JJ>
.
|
- cmd/bosun/conf/notify.go: Added two new metric 'bosun.post.sent' and 'bosun.post.sent_failed'
- cmd/bosun/web/web.go: New api api endpoint 'api/debug/{key}' to expose bosun internal debug and performance stats
- collect/collect.go: Added a new function 'Get', retrun current value of given metric from 'counters'
- docs/api.md: Update new endpoint 'api/debug/{key}'
1f0135c to
1949502
Compare
… '/api/health'
- cmd/bosun/web/web.go: remove '/api/debug/{key}' route and func 'DebugStats'
- docs/api.md: remove section 'Debug Endpoints' and updated '/api/health' doc
Contributor
Author
|
@kylebrandt / @captncraig can this merge along with #2217 Thanks, |
dschneller
added a commit
to Rheinwerk/bosun
that referenced
this pull request
Feb 26, 2018
* master: cmd/scollector: add systemd physical "predictable" linux net interface names (bosun-monitor#1985) cmd/bosun: add notification stats to /api/health (bosun-monitor#2222) cmd/bosun: native short links replace google (bosun-monitor#2210) docs: update system_configuration docs to reflect RedisDb configuration variable (bosun-monitor#2220) cmd/bosun/sched/views.go: added new incident filter `since` (bosun-monitor#2215) Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClose`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198) Update WMI to support int[] (bosun-monitor#2213) Add Scheme option to bosun toml (bosun-monitor#2209) Changed load sequence for `macros` to use in the notifications (bosun-monitor#2199) Fixed wrong nested ul in unknown notify (bosun-monitor#2208) travis: remove slack notification / go 1.9 (bosun-monitor#2203) Fix post notification logging (bosun-monitor#2196)
clinta
pushed a commit
to clinta/bosun
that referenced
this pull request
Mar 9, 2018
- Added new metrics 'bosun.post.sent' and 'bosun.post.sent_failed' - collect/collect.go: Added a new function 'Get', to return the current value of given metric from 'counters'
pradeepbbl
added a commit
to pradeepbbl/bosun
that referenced
this pull request
Mar 21, 2018
- Added new metrics 'bosun.post.sent' and 'bosun.post.sent_failed' - collect/collect.go: Added a new function 'Get', to return the current value of given metric from 'counters'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, bosun collects a bunch of runtime debug and performance stats and write it back to OpenTSDB. This endpoint will expose these stats, useful when you are not using Bosun with OpenTSDB.
At present, the endpoint only exposes
notificationsuccess and failure stats but we can add any other stats in future if required.Thanks,