This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Alert name macros in Graphite request header #2274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Alexander @sipidronov! |
Adds new configuration options for Elasticsearch to allow https, basic auth, custom names.
- conf/unknownNotify.go: added incident states to unknown context and a new func `IncidentUnknownLink` to build unknown incident link. - sched/notify.go: modified `sendUnknownNotifications` func to pass incident states. - docs/definitions.md: unknown template document update
Author
|
Will re-submit PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup for #2251 here's an implementation of passing Expression-specific data (alert-name in this case) into graphite context so that the config like
[GraphiteConf]Host = "localhost:80"[GraphiteConf.Headers]X-Meow = "Mix {alert-name}"Results in the following request to Graphite for "alert os.super-duper-high.cpu":
GET /render/?format=json&from=1530262155&target=%2A.cpu.%2A.cpu.idle%29&until=1530262455 HTTP/1.1Host: localhost:80User-Agent: Bosun/0.7.0-devX-Bosun-Server: c02w708ghv2tX-Meow: Mix os.super-duper-high.cpuAccept-Encoding: gzipIf the machinery looks good I'd expect macros substitution to be extended and optimised.