This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: added silence and status icons and ack state text on incident page #2271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd83074 to
479e92a
Compare
479e92a to
7f89727
Compare
kylebrandt
pushed a commit
that referenced
this pull request
Jun 28, 2018
Member
|
Merged in 865107d (Did a rebase and go generate into new branch since the static.go required a new |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
we found that on incident page are missing several icons that represents alert state.
On dashboard alerts and incidents has "silence" and "active" icons. So for the sake of unification we suggest to add these icons also to incident page.
also we made several improvements in incident page:
What your opinion about that? Thanks!