This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun remove not used errors column in rule editor #2270
+413
−413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
when testing alerts in Rule editor there's a table beneath the testing form.
this table should show number of alerts that resulted with errors, normals, crits and warnings:
Seems that 'Errors' column is left after this commit: e47fae4
where errors were moved outside of table. We suggest to remove this column from UI.
another suggestions: in case of several errors show them separately:
Another thing that's tricky to test with rule editor is unknowns. when you encounter unknown and try to reproduce it, you won't be able to do that with rule editor. Idea is to add a hint about this on the right side of test button:
Thanks!