This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun replace textarea with aceeditor in expr #2266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I do like changing this to the ace editor, however I'd like to see two changes:
|
Member
|
Oh, also the bosun logo animation seems to keep going until you run an expression, I think there is stop JS function to stop that on load |
Contributor
Author
|
@kylebrandt fixed review issues |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We have UX troubles trying to utilize Expr editor which is basically just textarea: it doesn't have syntax highlight and monospace font.
That's why we've implemented AceEditor to expr editor.
this is reimplementation of another PR
which seems to be abandoned: #2201
Thanks!