This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: added setting for example expression in *.toml #2261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da33dd9 to
b67f298
Compare
pradeepbbl
pushed a commit
to bookingcom/bosun
that referenced
this pull request
Jun 18, 2018
pradeepbbl
pushed a commit
to bookingcom/bosun
that referenced
this pull request
Jul 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request:
-Added optional setting in *.toml file "ExampleExpression" which allows to setup default expression under "Expression" tab in web UI.
-fixed bug: after testing of empty expression other expressions can not be tested (button stops sending expressions to test)
-added error message if user tests empty expression
Why it is needed: currently default expression is defined in expr.ts file and works properly if opentsdb is configured. In other environments (where graphite configured for example) after opening of "Expression" tab user sees error message "expr: non existent function q" that confuses him a bit.