This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: pass alert variables to unknown notification templates #2396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, @kylebrandt , @captncraig |
Contributor
|
It would be very useful to have this change |
Contributor
Member
|
@svagner we won't be able to accept this PR as it stands because there are no tests. We will still take a look though and consider it as soon as we can. |
Contributor
|
@tdinucci , thanks for the explanation! It makes great sense:) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2275 allows to pass alert variables to action notifications.
This PR allows this for unknown and multiple unknown notifications.