don't fetch indices , add indices to cache, and add esmonthly func #1931
Conversation
|
Currently if the time series is missing it errors inside ESDateHistrogram when it can't get the expected time series in the result. This result gets cached. Before when it would error on no indices in |
|
I think counting the resulting shards and erroring when there were no shards that matched will get the result I want. However, it depends on the following PR olivere/elastic#373 Alternatively, I could go for the date math method mentioned in #1926 (comment) . But only if |
9d96453 to
cf1315b
Compare
cf1315b to
719508b
Compare
|
note: forgot to fmt, force pushed the fmt. |
| return "", fmt.Errorf("failed to generate json representation of search source for cache key: %s", s) | ||
| } | ||
| return str, nil | ||
| return fmt.Sprintf("%v\n%s", r.Indices, b), nil |
There was a problem hiding this comment.
probably use string(b) here. Don't want [42 31 13] in you key.
There was a problem hiding this comment.
additionally, what does the source have that causes it to be a different key? What varies?
There was a problem hiding this comment.
I ask because it surprises me that something like getting a cache key even has a possibility of erroring.
|
fixes #1926 |
No description provided.