This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Have opentsdb.Duration implement encoding.TextUnmarshaler. #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Lgtm |
Member
|
If non blocking I'd like to review in morning before merge
…On Nov 30, 2016 19:17, "Craig Peterson" ***@***.***> wrote:
Lgtm
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1975 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABnT0PapSyNqF2_GiM8GSGkNgJ3rX6nmks5rDhI1gaJpZM4LA1Zi>
.
|
Contributor
Author
|
Not sure if I'll be around during your morning time. Mind prodding at this via comments? For further context, this is so I can json/toml unmarshal a file straight into a struct containing an |
Member
|
Nope don't mind that was my plan, sorry for not being clear. Just out
tonight so couldn't review until morning
On Nov 30, 2016 20:49, "Jason Harvey" ***@***.***> wrote:
Not sure if I'll be around during your morning time. Mind prodding at
this via comments?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
|
Contributor
Author
|
Gotcha, works for me. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👓 @captncraig @kylebrandt
Will be using this to read durations from a config file on a separate utility.