This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/scollector: mssql.agent.* for monitoring SQL Agent jobs #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ready for code review. Testing on ny-devbosun (see http://goo.gl/5GPH57 ) |
71df5ad to
826bf78
Compare
Contributor
Author
|
one of the metrics had a wrong type (WMI said it was a counter but really was a gauge). Testing again overnight and should be ready to merge tomorrow if there are no issues. |
| label := "mssqlserver" | ||
| if w.Name != `SQLSERVERAGENT` { | ||
| q = instanceAgentWMIQuery(w.Name, q) | ||
| label = strings.ToLower(w.Name[8:len(w.Name)]) |
Member
There was a problem hiding this comment.
Do you know that w.Name can not be shorter than 8?
Contributor
Author
There was a problem hiding this comment.
yes, it is either SQLSERVERAGENT or SQLAgent$+Instance Name
Contributor
Author
There was a problem hiding this comment.
ah does look like there is an off by one error though... should be 9. I'll wrap it in a length check too, since WMI sometimes goes crazy and returns default values like 0 / ""
826bf78 to
c71f21b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.