This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: adding "unknownIsNormal" flag to alerts to convert unknown events into normal ones. #1620
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/bosun/conf/conf.go
Outdated
| Unknown time.Duration | ||
| MaxLogFrequency time.Duration | ||
| IgnoreUnknown bool | ||
| UnkownsNormal bool |
e6a2325 to
65a77a3
Compare
… events into normal ones.
65a77a3 to
c5a5316
Compare
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply replaces the event status in run history. Should help with things like #1160 where sparse data is expected.
It will end up creating a normal event for all alert keys every 2 check cycles once they disappear. Not sure how to prevent that. Maybe it would be better to suppress unknown generation at all for these alerts, but then they are unclosable, so never-mind.