cmd/bosun: series func to create series from scalars #1667
Conversation
d5aeb97 to
231c38a
Compare
|
Also fixes #1655 |
| F interface{} | ||
| VArgs bool | ||
| VArgsPos int | ||
| VArgsOmit bool |
There was a problem hiding this comment.
What does VArgsOmit do?
There was a problem hiding this comment.
@captncraig Makes it so the vargs are optional. You are allowed to omit them.
There was a problem hiding this comment.
How about inverting it. Maybe VArgsRequired or even MinVArgs would be clearer.
There was a problem hiding this comment.
Most of the time it isn't true. So when defining funcs you don't have to
include it. So false is a better default
On Mon, Mar 14, 2016 at 1:19 PM, Craig Peterson notifications@github.com
wrote:
In cmd/bosun/expr/parse/parse.go
#1667 (comment):@@ -31,13 +31,14 @@ type Tree struct {
}type Func struct {
- Args []models.FuncType
- Return models.FuncType
- Tags func([]Node) (Tags, error)
- F interface{}
- VArgs bool
- VArgsPos int
- Check func(*Tree, *FuncNode) error
- Args []models.FuncType
- Return models.FuncType
- Tags func([]Node) (Tags, error)
- F interface{}
- VArgs bool
- VArgsPos int
- VArgsOmit bool
How about inverting it. Maybe VArgsRequired or even MinVArgs would be
clearer.—
Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/pull/1667/files#r56038601.
Also fix nv() so it creates a result when the entire set is empty