Elastic v2 support and elastic expr refactor #1561
Conversation
cef73e4 to
b0c5e69
Compare
f11b849 to
7c81677
Compare
9295160 to
2782dd1
Compare
docs/expressions.md
Outdated
There was a problem hiding this comment.
generate indexes? do you mean generate index names [for which indexes to be queried] ?
There was a problem hiding this comment.
Yes, index names, will update. Thanks!
|
Nice work Kyle! Thanks. |
|
this looks great @kylebrandt! Can't wait to try it (hopefully this week). Quick question are you planning to handle the scenario mentioned in #1160 as part of this work? |
|
@deanefrati I looked at this and didn't want to do it in this PR, but will make sure it is on my radar for soon. I think that issue is impacting us at stack well to make elastic usable for alerts. I just had enough to wrap my head around with elastic's API changing, the elastic go library decided that was a good time to do some refactoring since elastic changed, and then I decided it was a good time to do it in bosun too. That is about as much as I could hold in my head :-P |
|
makes total sense. thanks again |
999d6f0 to
9207d1d
Compare
cmd/bosun/conf/conf.go
Outdated
There was a problem hiding this comment.
I would like this to be more clear which is for v1 and which is for v2
There was a problem hiding this comment.
@captncraig updated comments and the documentation.
cmd/bosun/expr/elastic.go
Outdated
There was a problem hiding this comment.
VArgs: false and VargsPos: 1? I'm not sure what that combination means.
No description provided.