Persist last to redis #1402
Persist last to redis #1402
Conversation
cmd/bosun/database/database.go
Outdated
There was a problem hiding this comment.
Why underscore here? Should it be a package, method on something, etc? Seems fishy...?
There was a problem hiding this comment.
The whole naming is odd. I was trying to segregate the search methods, but there are too many now. I will probably segregate to data.Search.GetWhatever() with a nested interface.
70db7e3 to
f38bcf6
Compare
There was a problem hiding this comment.
dp.Timestamp-p.Timestamp - Check for Div by Zero?
There was a problem hiding this comment.
Actually, we already verified that p.timestamp < dp.Timestamp. therefore dp.Timestamp-p.Timestamp will always be greater than zero.
f38bcf6 to
09ae7ac
Compare
09ae7ac to
3e522b1
Compare
|
so what exactly does this persist? |
|
Pretty much so it survives restarts. This data is used to serve a host page on opserver, and kyle wanted it to be available fast. If it gets cleared on restarts, funny things happen. I would argue that perhaps that endpoint should be served from opentsdb data, but I think there were good reasons against that. Perhaps @kylebrandt can refresh me. |
No description provided.