这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Fix to last logic for template rendering. #1470

Closed
wants to merge 1 commit into from
Closed

Fix to last logic for template rendering. #1470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions cmd/bosun/sched/check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,16 @@ func (s *Schedule) runHistory(r *RunHistory, ak models.AlertKey, event *Event, s
}
// add new event to state
last := state.AbnormalStatus()
wasOpen := state.Open
// last could be StNone if it is new. Set it to normal if so because StNormal >
// StNone. If the state is not open (closed), then the last state we care about
// isn't the last abnormal state, it's just normal.
if last < StNormal || !wasOpen {
last = StNormal
}
state.Append(event)
a := s.Conf.Alerts[ak.Name()]
wasOpen := state.Open

// render templates and open alert key if abnormal
if event.Status > StNormal {
if event.Status >= last {
Expand Down Expand Up @@ -230,12 +237,7 @@ func (s *Schedule) runHistory(r *RunHistory, ak models.AlertKey, event *Event, s
}
// lock while we change notifications.
s.Lock("RunHistory")
// last could be StNone if it is new. Set it to normal if so because StNormal >
// StNone. If the state is not open (closed), then the last state we care about
// isn't the last abnormal state, it's just normal.
if last < StNormal || !wasOpen {
last = StNormal
}

if event.Status > last {
clearOld()
notifyCurrent()
Expand Down