This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: Export time.ParseDuration as ParseDuration to templates #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/bosun/conf/conf.go
Outdated
Contributor
There was a problem hiding this comment.
lower case looks to be the convention. parseDuration
Contributor
|
@kylebrandt what problem does this solve. It looks like @ayashjorden solved #1014 without it. |
Member
Author
|
@captncraig See the associated issue. It makes it so we don't have to do some string replacement or ugly constants in the templates. |
Contributor
|
ok, change to parseDuration and merge. |
ba0da02 to
e47c472
Compare
kylebrandt
added a commit
that referenced
this pull request
Jul 27, 2015
cmd/bosun: Export time.ParseDuration as ParseDuration to templates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1014