cmd/scollector: RabbitMQ #1202
cmd/scollector: RabbitMQ #1202
Conversation
cmd/scollector/doc.go
Outdated
There was a problem hiding this comment.
perhaps document that it will check localhost, even with no config given.
|
One of the problems I've encountered is |
|
That would be an acceptable use of an interface{} field. Most others look like they could be mapped into structs. Have you seen this tool: http://mholt.github.io/json-to-go/? |
|
Yeah, seen that, will do some research on how does RMQ output stats in different versions. |
|
@dimamedvedev Also the gojson as a local utility is quite nice https://github.com/ChimeraCoder/gojson , you just do |
10de452 to
c65c98d
Compare
|
There was a problem hiding this comment.
These could be tagged, not 100% sure.
1f6af72 to
91de289
Compare
There was a problem hiding this comment.
You don't even need to read the body prior to this. Just use json.NewDecoder(res.Body)
|
@captncraig updated PR, will squash when ready |
There was a problem hiding this comment.
You are adding the same two data points twice, with different tagsets (once with direction and method, once with only direction). This scheme seems like it may cause confusing data conditions. Why Not have just the first two Adds and the last one?
There was a problem hiding this comment.
Oh, my bad, easy to get lost in so many metrics. Used wrong datapoints. Thank you for being thorough.
ab3f1f0 to
98bf1d1
Compare
98bf1d1 to
f74cdf1
Compare
Fairly comprehensive collector for RabbitMQ 3.x Probably needs careful review of metric/tags design.