Compile error fixes + negative filter patterns + total_time metric for httpunit collector #1263
Conversation
|
Implemented another feature in this branch since I need the previous changes I made. BR /AR |
|
the negative filter patterns would be awesome. Example: I want to disable cassandra monitoring, but everything else should stay on. |
There was a problem hiding this comment.
You shouldn't edit files in _third_party directly. Instead this feature will need to be a seperate pr to github.com/StackExchange/httpunit
There was a problem hiding this comment.
Ok I will look into that next week.
There was a problem hiding this comment.
I merged over my changes to httpunit, I did not merge back the changes from httpunit here yet (some timeout improvements): StackExchange/httpunit#5
|
Yet another small feature in this fork, Freq setting for HTTPUnit collectors. The default Freq if missing in the toml file is the same as the previously hardcoded value, 5 minutes. |
|
Sorry this has sat so long. Can you please squash and rebase to master? |
There was a problem hiding this comment.
I'd like this documented. Is this seconds? minutes? something else? cmd/scollector/doc.go should have docs for this.
|
Squash rebase, sure np. Should I remove the windows build helper script? It's just a personal convenience thing to enable autocomplete from windows command line. |
|
I would say remove the build.scollector_win.bat file, as our build scripts are usually based in go. You can keep it in your local repo and add it to a global ignore if you still want to use it. |
Negative filter patterns ("-" prefix),
Added time_total metric to httpunit collector,
Freq setting for HTTPUnit collectors.
|
Rebased, squashed, added some info for Freq in cmd/scollector/doc.go. |
|
Sorry for the delay. This was merged as part of #1630 |
|
Oh, cool. Thanks for the info. |
also add a log message when metrics are being filtered since I spent 20 minutes trying to figure out why my -p and -f tests were not working closes bosun-monitor#1263
Can now disable collectors using filter patterns prefixed by "-", eg. scollector-windows-amd64.exe -p -d -l -f="network_windows,-tcp" on my dev. machine prints:
bosun.org/cmd/scollector/collectors.c_network_windows
(excluding c_network_windows_tcp)
I needed this specifically for disabling c_network_windows_tcp while keeping c_network_windows enabled, trying to find performance issues caused by one of the two collectors, or both. High CPU usage by WmiPrvSE.exe and blocked collectors seems to be the symptoms (have not solved the issue or confirmed the offending collector yet)
Edit: It was not one of the network collectors. Could be some WMI related issue. It seems like the issue mostly occurs when the machines are under heavy load.