This repository was archived by the owner on Feb 13, 2025. It is now read-only.
bosun: Validating user and message on action. Requiring message to send notifications. #1167
+362
−337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Fine with me when the Send Notification box is checked. I often don't want to send notifications when I am just clearing the dashboard, so having it prompt would remind me to uncheck the box :-P |
273fa83 to
e17f090
Compare
captncraig
added a commit
that referenced
this pull request
Jul 15, 2015
bosun: Validating user and message on action. Requiring message to send notifications.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply highlights erroneous fields and doesn't submit.
I am still not sure if this is a good idea or not.