This change only covers adding the User-Agent header. The HTTP notification code could use a refactor to removing some duplication in the code.

The version package could also be refactored to include either a method returning the value for the User-Agent instead of having to build the userAgent variable in the init function.

We already set http.DefaultClient to a custom client here:

Any changes should be made there. Adding a "ShortVersion()" function to the version package would be ok by me as well.

@captncraig ah, great, I'll use http.DefaultClient then. Sadly, custom headers cannot be set in the default client but only in Request.Header, unless I'm missing something. I'll double check.

I'll work on the ShortVersion function too.

I would think we should set up out main client to set the user-agent on every request. That can be done with a custom RoundTripper. Something like this: https://play.golang.org/p/_E6fRYPvrN

@captncraig I've applied your suggestions. I think the initialization of the client could probably be done in a nicer way than this. I'd like to know your thoughts.

LGTM. How do you feel about this implementation @mjibson ?

Implementation looks good after my one comment. What problem does this solve, or why is it needed?

What problem does this solve, or why is it needed?

It isn't really a problem what is solving, maybe a best practice. At work we're working on a custom notifications aggregator, which several other services sending HTTP notifications. We record all the information received and use the User-Agent header to identify which service was the one sending the notification. I'm aware HTTP headers are easily spoofed, but this will mostly internal, so it's not a concern. And in our case, using the User-Agent for identification is easier than checking the remote IP, for instance.

I'll see to fix that line you pointed me, sorry for the delay. Thanks!

Closing. Will merge commit in #1265

Thanks!