Reviewed 9 of 10 files at r1.
Review status: 9 of 10 files reviewed at latest revision, 11 unresolved discussions, all commit checks successful.

^{cmd/scollector/collectors/dsc_windows.go, line 10 [r1] (raw file):}
No need to name this.

^{cmd/scollector/collectors/dsc_windows.go, line 86 [r1] (raw file):}
need to check for error

^{cmd/scollector/collectors/dsc_windows.go, line 104 [r1] (raw file):}
no need for , _

^{cmd/scollector/collectors/dsc_windows.go, line 105 [r1] (raw file):}
c.Success++ is fine

^{cmd/scollector/collectors/dsc_windows.go, line 109 [r1] (raw file):}
same as above

^{cmd/scollector/collectors/dsc_windows.go, line 123 [r1] (raw file):}
. at EOL

^{cmd/scollector/collectors/dsc_windows.go, line 130 [r1] (raw file):}
"Time in seconds" or just "Seconds" taken...

^{cmd/scollector/collectors/dsc_windows.go, line 174 [r1] (raw file):}

switch mode {
case "PULL":
  return 0
...

^{cmd/scollector/collectors/dsc_windows.go, line 187 [r1] (raw file):}

switch t {
case "Reboot":
  return 0
...

^{cmd/scollector/collectors/dsc_windows.go, line 204 [r1] (raw file):}
nope, gotta return errors all the way up or ignore them. collectors don't ever log errors.

^{cmd/scollector/collectors/dsc_windows.go, line 207 [r1] (raw file):}
I'm not really a fan of using time.Now() for this. Much more inclined to record the actual timestamp and compute things from that instead.

Comments from the review on Reviewable.io

Reviewed 1 of 10 files at r1.
Review status: all files reviewed at latest revision, 11 unresolved discussions, all commit checks successful.

Comments from the review on Reviewable.io

Review status: 9 of 10 files reviewed at latest revision, 11 unresolved discussions, some commit checks pending.

^{cmd/scollector/collectors/dsc_windows.go, line 10 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 86 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 104 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 105 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 109 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 123 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 130 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 174 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 204 [r1] (raw file):}
Done.

^{cmd/scollector/collectors/dsc_windows.go, line 207 [r1] (raw file):}
Do you mean run_start_time instead of run_age? Had a discussion about that in slack today https://bosun.slack.com/archives/general/p1434645366001374

I feel pretty strong about this being seconds since and not a timestamp. Lets jump on a hangout tomorrow if you want to talk about it.

Comments from the review on Reviewable.io

Review status: 9 of 10 files reviewed at latest revision, 11 unresolved discussions, some commit checks pending.

^{cmd/scollector/collectors/dsc_windows.go, line 187 [r1] (raw file):}
Done.

Comments from the review on Reviewable.io

Review status: 9 of 10 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

^{cmd/scollector/collectors/dsc_windows.go, line 207 [r1] (raw file):}
Talk to Kyle about this.

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from the review on Reviewable.io

@mjibson or @captncraig This is ready for a final review before merging. I talked with Kyle about the Age vs Timestamp and he was fine with Age.

You can merge this yourself after you fix the imports list.