This repository was archived by the owner on Feb 13, 2025. It is now read-only.
travis: pin Typescript to version 1.5.3 and fix Esc ModTime issues #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newest version is 1.6-beta, and is quite strict. I don't have the typescript fu to fix that. Since mjibson's esc module has updated too, I reran go generate.
9df4f63 to
5882946
Compare
5882946 to
89d72be
Compare
Contributor
Author
|
Looks like Esc is working again. We had to override the modtime feature that was added to Esc recently and It looks like on Windows you need to use autocrlf = input to prevent issues with line endings. I also updated the go generate call for Tsc to only replace the file if changes were actually made. I think it was updating the timestamp or line endings which caused some issues. This is passing travis CI now, I'll have someone else test locally after running |
gbrayut
added a commit
that referenced
this pull request
Sep 9, 2015
travis: pin Typescript to version 1.5.3 and fix Esc ModTime issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.