fix(core): improved timeout behavior #12470
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // if there is no jump, so we don't want the timeout event to process the previous queue | ||
| // The reason to return the event is to persist any changes made to session state or context | ||
| // in the session timeout hook | ||
| fakeEvent.state.context = { ...session.context, queue: undefined } as IO.DialogContext |
There was a problem hiding this comment.
I'm not so familiar with dialog engine, should queue be an empty array instead of undefined ?
There was a problem hiding this comment.
Should be undefined, an empty query will generate an error
There was a problem hiding this comment.
when the queue is undefined, the dialog engine will use the active flow/node to build the instruction queue
|
|
||
| this.fillContextForTransition(event, { currentFlow, currentNode, nextFlow: timeoutFlow, nextNode: timeoutNode }) | ||
|
|
||
| // Process the event with the new context, return to persist state changes |
There was a problem hiding this comment.
what if there is no timeoutNode/timeoutFlow ? we don't throw anymore >
There was a problem hiding this comment.
Yes, it will not throw an error since that, in my opinion, it can't be considered an error to not have a timeout flow/node; instead,
- if there is no jump (transition), return the event to have its state saved (If we modify the state in the timeout hook for example)
- if there was a jump in the timeout hook or timeout flow/node, process the event and save the state (including the context, which will make it possible to continue the conversation if desired).
The previous logic created an bug where changes made in the timeout hook to session state would not be saved unless we had a timeout node/flow
allardy
left a comment
There was a problem hiding this comment.
LGTM. I didn't test it out but the logic make sense
| // if there is no jump, so we don't want the timeout event to process the previous queue | ||
| // The reason to return the event is to persist any changes made to session state or context | ||
| // in the session timeout hook | ||
| fakeEvent.state.context = { ...session.context, queue: undefined } as IO.DialogContext |
There was a problem hiding this comment.
when the queue is undefined, the dialog engine will use the active flow/node to build the instruction queue
This PR fixes the conversation timeout behavior with the following items: