feat(integrations/telegram): add support for standard markdown #14060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… splitRangeTestCases
- The markdown "__{text}__" was actually an alternative markdown for bold not italic
- Changed italic effect markdown from "_{text}_" to "*{text}*" since the underscore markdown only works when it's adjacent to whitespace in the text
…thin larger segments
- This is because we don't need to sort if there's only 1 or less elements
…partially nests a smaller segment
… specific test case
a30809b to
c54d8e4
Compare
| test.each(telegramToMarkdownTestCases)('$description', ({ input, expects }: TelegramToMarkdownTestCase) => { | ||
| const consoleWarn = console.warn | ||
|
|
||
| console.warn = (firstArg: unknown, ...args: unknown[]) => { |
There was a problem hiding this comment.
issue: This strategy will stop working as soon as you change the log message. Instead, your function applyMarksToText should return a list of warnings and errors. You can use these warnings in your tests and also log them in the actual integration's implementation
| consoleWarn(firstArg, ...args) | ||
| } | ||
|
|
||
| expect(applyMarksToText(input.text, input.marks)).toBe(expects) |
There was a problem hiding this comment.
chore: As we've already discussed in person, you shouldn't test internal private functions directly. These are implementation details and should be allowed to change without affecting the tests
2297dc4 to
f4463e2
Compare
…h test case order
…ince it is an ignored effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Linear issue SQD-3049