这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented May 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21260

📔 Objective

We currently ignore node and npm (among others) here.

For consistency, we'd like to move this to the default configuration so that other repositories using npm and node have the same configuration.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Add ignored dependencies for npm and node [PM-21260] Add ignored dependencies for npm and node May 6, 2025
@trmartin4 trmartin4 marked this pull request as ready for review May 6, 2025 19:58
@trmartin4 trmartin4 requested a review from eliykat May 6, 2025 19:58
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trmartin4 , appreciate your help here!

@trmartin4 trmartin4 merged commit c0f0b63 into main May 7, 2025
2 checks passed
@trmartin4 trmartin4 deleted the platform/add-ignored-dependencies branch May 7, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants