这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented May 5, 2025

🎟️ Tracking

npm: https://bitwarden.atlassian.net/browse/PM-17637
nuget: https://bitwarden.atlassian.net/browse/PM-17239

📔 Objective

This PR changes how we manage patch updates for npm and nuget. It changes these package managers to, by default, not automatically open PRs for patch updates.

We do want to build in exceptions to this default behavior, which are captured in these related PRs:

clients: bitwarden/clients#14655
server: bitwarden/server#5775

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Updated default to send npm and nuget to dashboard Update default to send npm and nuget patch updates to dashboard May 5, 2025
@trmartin4 trmartin4 marked this pull request as ready for review May 6, 2025 18:26
withinfocus
withinfocus previously approved these changes May 7, 2025
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
@trmartin4 trmartin4 merged commit 653e920 into main May 7, 2025
2 checks passed
@trmartin4 trmartin4 deleted the platform/send-npm-nuget-patch-updates-to-dashboard branch May 7, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants