[PM-20478] Remove not-pending status check #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-20476
📔 Objective
In #18, I added
"prCreation": "not-pending", based on the recommendation in this discussion on the Renovate forums. This appeared to be an undocumented requirement in order for theminimumReleaseAgeto work.However, we're now seeing behavior that PRs are not being created for dependencies that do meet the minimum release age. After debugging the runs, it appears that this is because the
not-pendingcheck is preventing the creation of a PR due to the fact that we don't have any commit checks. After querying for branch status, we get this log message:As this puts the branch in
pending, our restriction to anot-pendingstatus prevents the PR from being created.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes