Add max and min utils #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dictor93
suggested changes
Dec 8, 2023
Contributor
dictor93
left a comment
There was a problem hiding this comment.
Small comments. The rest LGTM!
src/max.js
Outdated
|
|
||
| const determineExtremumValue = require('./util/determineExtremumValue') | ||
|
|
||
| const min = (array) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| const min = (array) => { | |
| const max = (array) => { |
Member
Author
There was a problem hiding this comment.
indeed, thanks for typo detection
src/max.js
Outdated
| ) | ||
| } | ||
|
|
||
| module.exports = min |
Contributor
There was a problem hiding this comment.
Suggested change
| module.exports = min | |
| module.exports = max |
|
|
||
| return array.reduce((prev, curr) => { | ||
| if (isNil(curr)) { | ||
| return prev |
Contributor
There was a problem hiding this comment.
Seems, this condition is not covered by tests
ezewer
approved these changes
Dec 11, 2023
ezewer
left a comment
There was a problem hiding this comment.
Code looks good to me, please add a test for letters as to prove this also works for text
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
maxandminutilsNew features:
maxutilminutilPR status: