这是indexloc提供的服务，不要输入任何密码
Skip to content

[PART-2] Add transaction tax report #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2024
Merged

[PART-2] Add transaction tax report #381

merged 3 commits into from
May 23, 2024

Conversation

@ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented May 22, 2024

This PR adds exactUsdValue field to ledgers, trades and movements tables for Transaction Tax Report

It's a 1-part of the feature, the main idea taken from these PRs: #373, #378, #379

  • separates into small parts
  • improves and speeds up the currency conversion approach

Basic changes:

  • adds exactUsdValue field to corresponding tables
  • adds v41 DB migration

ezewer
ezewer approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 6aa4483 into bitfinexcom:staging May 23, 2024
This was referenced Jul 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezewer ezewer ezewer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZIMkaRU @ezewer