这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Mar 28, 2024

This PR extends error logs for sync proc


The idea is to add serializedError field to the error object with a serialized error string that contains composed error metadata for easier debugging of the user's error reports. This field will be used for logging in case catching error occurs during sync


Example of logs:

WORKER:ERROR [2024-03-28T10:27:37.780Z] PROGRESS:SYNC:     HTTP code 500 Internal Server Error    
  - METHOD_NAME: getCandles    
  - STATUS_CODE: 500    
  - STATUS_MESSAGE: Internal Server Error    
  - DATA: {
      "bfxApiErrorMessage": {
        "bfxApiStatus": 500,
        "bfxApiStatusText": "Internal Server Error",
        "bfxApiRawBodyCode": 10020,
        "isBfxApiRawBodyResponseHtml": false,
        "bfxApiRawBodyResponse": "time_interval: invalid"
      }
    }    
  - STACK_TRACE Error: HTTP code 500 Internal Server Error
    at Proxy._apiError (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-api-node-rest/lib/rest2.js:164:17)
    at /home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/get-rest.js:51:19
    at BfxApiRouter.route (/home/vladimir/projects/bitfinex/bfx-reports-framework/workers/loc.api/bfx.api.router/index.js:70:14)
    at _route (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/get-rest.js:49:23)
    at Object.apply (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/get-rest.js:121:27)
    at Proxy._request (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-api-node-rest/lib/rest2.js:150:26)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async _asyncApplyHook (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/get-rest.js:65:21)
    at async _asyncApplyHook (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/get-rest.js:65:21)
    at async _asyncApplyHook (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/get-rest.js:65:21)
    at async _getResAndParams (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/prepare-response/index.js:54:18)
    at async FrameworkReportService._prepareApiResponse (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/prepare-response/index.js:152:19)
    at async ApiMiddleware.request (/home/vladimir/projects/bitfinex/bfx-reports-framework/workers/loc.api/sync/data.inserter/api.middleware/index.js:32:20)
    at async DataInserter.getDataFromApi (/home/vladimir/projects/bitfinex/bfx-reports-framework/node_modules/bfx-report/workers/loc.api/helpers/get-data-from-api.js:93:15)
    at async DataInserter._insertApiDataArrObjTypeToDb (/home/vladimir/projects/bitfinex/bfx-reports-framework/workers/loc.api/sync/data.inserter/index.js:566:11)
    at async DataInserter._insertApiData (/home/vladimir/projects/bitfinex/bfx-reports-framework/workers/loc.api/sync/data.inserter/index.js:499:7)

Depends on this PR:

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants