Add exchange volume and trading fee values to summary by asset #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2543bdd to
8f27a1d
Compare
1 task
0f89ba2 to
036821e
Compare
036821e to
c226e93
Compare
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exchange volume and trading fee values to the summary by asset
Adds the following:
volume: takes from trades, should be in base currency, egBTCvolumeUsd:amountUsd, the same as forgetTradedVolumeendpointtradingFees: takes from ledgers category201, should be in base currency, egBTCtradingFeesUsd: the same astradingFeesbut usesamountUsdfield to take into account the price for the timestamp of the transactionmarginFundingPayment: takes from ledgers category28, should be in base currency, egBTCResponse example:
{ "jsonrpc": "2.0", "result": { "summaryByAsset": [ { "currency": "XDC", "balance": 0.123, "balanceUsd": 0.123, "balanceChange": 0.123, "balanceChangePerc": 123, "volume": 12.123, "volumeUsd": 12.123, "tradingFees": 0.123, "marginFundingPayment": 0 } ], "total": { "balanceUsd": 12.123, "balanceChangeUsd": 12.123, "balanceChangePerc": 123.123, "volumeUsd": 1234.123, "tradingFeesUsd": 1.123 } }, "id": null }