-
Notifications
You must be signed in to change notification settings - Fork 16
Add username/pwd auth support #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
prdn
merged 73 commits into
bitfinexcom:beta
from
ZIMkaRU:feature/add-username-pwd-auth-support
Feb 22, 2023
Merged
Add username/pwd auth support #256
prdn
merged 73 commits into
bitfinexcom:beta
from
ZIMkaRU:feature/add-username-pwd-auth-support
Feb 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Beta version 4.1.1 to master
ezewer
approved these changes
Feb 21, 2023
Contributor
ezewer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds BFX auth token support to framework mode
The flow is the following:
signUp/signInendpoints.getUsersendpoint shows that the account may not be used for sub-account when uses auth token{ "method": "getUsers" }{ "jsonrpc": "2.0", "result": [ { "email": "user@email.com", "isSubAccount": false, "isNotProtected": true, "subUsers": [], "isRestrictedToBeAddedToSubAccount": false // the corresponding flag } ], "id": null }signUpneed to useauthTokeninstead ofapiKey/apiSecret, the rest params are the same{ "method": "signUp", "auth": { "authToken": "pub:api:88888888-4444-3333-2222-121212121212-caps:s:o:f:w:wd:a-write", "isNotProtected": true } }{ "jsonrpc": "2.0", "result": { "email": "user@email.com", "isSubAccount": false, "token": "160f22c1-8c01-48b2-8a3b-42a8e734ffeb" }, "id": null }{ "jsonrpc": "2.0", "result": { "isAuthTokenGenError": true }, "id": null, "action": "emitBfxUnamePwdAuthRequired" }signInendpoint with the new auth token{ "method": "signIn", "auth": { "authToken": "pub:api:NEW88888-4444-3333-2222-121212121212-caps:s:o:f:w:wd:a-write", "email": "user@email.com", "isNotProtected": true } }{ "jsonrpc": "2.0", "result": { "email": "user@email.com", "isSubAccount": false, "token": "60ca9999-0d29-46ed-a048-0d45be7b2aa0" }, "id": null }signUp/signIn, it's possible to take atokenfrom the response, it's a local token (that we use with apiKeys flow), and it can be used in the same way as before on the UI side without any changesrecoverPasswordendpoint is available for auth token{ "method": "recoverPassword", "auth": { "authToken": "pub:api:NEW88888-4444-3333-2222-121212121212-caps:s:o:f:w:wd:a-write", "newPassword": "1234567890qwerty" } }{ "jsonrpc": "2.0", "result": { "email": "user@email.com", "isSubAccount": false, "token": "60ca9999-0d29-46ed-a048-0d45be7b2aa0" }, "id": null }authTokenis stored in the DB in encrypted form as it's done for API keys, and we can also use the user password for this purpose as we do for API keysBasic changes:
Depends on this PR: