Add estimated sync time to progress state #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds estimated sync time to the progress state and changes corresponding test coverage. The idea:
getSyncProgressendpoint, check below a description of returning dataBreaking changes:
getSyncProgressendpoint andemitProgressWS event return the following data structure:{ progress, // as previously value syncStartedAt, // null || millisecond timestamp, e.g. `Date.now()` spentTime, // null || millisecond difference leftTime // null || millisecond difference }instead of just
progressvalue as it was beforeUI flow:
syncStartedAtandspentTimeandleftTimeonly when sync is going onnull. So ifprogressis not thenumberdon't show the estimated timesyncStartedAt,spentTime,leftTimeisnullthen, for that variable, showEstimating...or something similar instead of justnull