-
Notifications
You must be signed in to change notification settings - Fork 16
Implement new sync core to use temp tables #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
prdn
merged 243 commits into
bitfinexcom:beta
from
ZIMkaRU:feature/improve-sync-process-with-temp-tables
Dec 2, 2022
Merged
Implement new sync core to use temp tables #240
prdn
merged 243 commits into
bitfinexcom:beta
from
ZIMkaRU:feature/improve-sync-process-with-temp-tables
Dec 2, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing added/removed
ezewer
approved these changes
Dec 2, 2022
Contributor
ezewer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new sync core to use temp tables during sync processing. The main idea is to put data fetched from the BFX
api_v2to temp tables to have consistent data in the main tables and allow users to request reports from all sections any time even sync is going on, except the first sync when the DB is empty. When the sync is finished and temp tables are filled all data will be moved to the main tables in one atomic transaction thus users don't have to experience transitional processes. Basic changes:database is lockedissueapi_v2, adds fetching data retriesv31api_v2, which increases the speed of the syncpragma analysis_limitto400for performanceapi_v2for syncing data to speed up